mirror of
https://github.com/docker/docker-bench-security.git
synced 2025-01-18 16:22:33 +01:00
Fix test 5.14 to not always pass when multiple ports are published.
Signed-off-by: Zvi "Viz" Effron <zeffron@riotgames.com>
This commit is contained in:
parent
0e7967e9b0
commit
3616f15cba
1 changed files with 11 additions and 10 deletions
|
@ -319,17 +319,18 @@ else
|
|||
|
||||
fail=0
|
||||
for c in $containers; do
|
||||
ip=$(docker port "$c" | awk '{print $3}' | cut -d ':' -f1)
|
||||
if [ "$ip" = "0.0.0.0" ]; then
|
||||
# If it's the first container, fail the test
|
||||
if [ $fail -eq 0 ]; then
|
||||
warn "$check_5_14"
|
||||
warn " * Port being bound to wildcard IP: $ip in $c"
|
||||
fail=1
|
||||
else
|
||||
warn " * Port being bound to wildcard IP: $ip in $c"
|
||||
for ip in $(docker port "$c" | awk '{print $3}' | cut -d ':' -f1); do
|
||||
if [ "$ip" = "0.0.0.0" ]; then
|
||||
# If it's the first container, fail the test
|
||||
if [ $fail -eq 0 ]; then
|
||||
warn "$check_5_14"
|
||||
warn " * Port being bound to wildcard IP: $ip in $c"
|
||||
fail=1
|
||||
else
|
||||
warn " * Port being bound to wildcard IP: $ip in $c"
|
||||
fi
|
||||
fi
|
||||
fi
|
||||
done
|
||||
done
|
||||
# We went through all the containers and found no ports bound to 0.0.0.0
|
||||
if [ $fail -eq 0 ]; then
|
||||
|
|
Loading…
Reference in a new issue