From 3d2565742a16392e08d8d42dafd67956480d875e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Sj=C3=B6gren?= Date: Fri, 19 Jun 2015 23:46:43 +0200 Subject: [PATCH 1/3] same build instructions everywhere MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Sjögren --- CONTRIBUTING.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 36d2d2f..1b9fe4f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -19,12 +19,15 @@ The only thing you need to hack on Docker Bench for Security is a POSIX 2004 com You can build the container that wraps the docker-bench for security: ```sh ✗ git clone git@github.com:docker/docker-bench-security.git -✗ docker build -t diogomonica/docker-bench-security . +✗ cd docker-bench-security +✗ docker build -t docker-bench-security . ``` Or you can simply run the shell script locally: ```sh +✗ git clone git@github.com:docker/docker-bench-security.git +✗ cd docker-bench-security ✗ sh docker-bench-security.sh ``` From 0b32b8aa220e3f4e6fe1c84ca7bdc1faef39de79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Sj=C3=B6gren?= Date: Fri, 19 Jun 2015 23:47:27 +0200 Subject: [PATCH 2/3] codecheck w shellcheck, checkbashisms MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Sjögren --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1b9fe4f..ae2c13b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,6 +46,6 @@ tests └── 6_docker_security_operations.sh ``` -To modify the Docker Bench for Security you should first clone the repository, make your changes, and then sign off on your commits. After that feel free to send us a pull-request with the changes. +To modify the Docker Bench for Security you should first clone the repository, make your changes, check your code with `shellcheck`, `checkbashisms` or similar tools, and then sign off on your commits. After that feel free to send us a pull-request with the changes. While this tool is inspired in the CIS Docker 1.6 Benchmark, feel free to add new tests. We will try to turn dockerbench.com into a list of good community benchmarks for both security and performance, and we would love community contributions. From b808610b459af93903568c6900b3bf898e6bd58a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Sj=C3=B6gren?= Date: Fri, 19 Jun 2015 23:52:01 +0200 Subject: [PATCH 3/3] simplify dir tree MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Thomas Sjögren --- CONTRIBUTING.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ae2c13b..b3bda6c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,8 +36,7 @@ The Docker Bench has the main script called `docker-bench-security.sh`. This is The tests are split in 6 different files: ```sh -✗ docker-bench-security git:(master) ✗ tree tests -tests +✗ tests ├── 1_host_configuration.sh ├── 2_docker_daemon_configuration.sh ├── 3_docker_daemon_configuration_files.sh