GuillaumeHemmen/docker-bench-security
1
0
Fork 0
mirror of https://github.com/docker/docker-bench-security.git synced 2025-01-19 00:32:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #76 from konstruktoid/prettier_output

Browse source 
prettier Docker exec fail output
This commit is contained in:
Thomas Sjögren 2015-08-13 22:38:51 +02:00
commit f4e5cfd7df
1 changed files with 26 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
tests/5_container_runtime.sh
View file

@ -60,14 +60,8 @@ else
check_5_3="5.3 - Verify that containers are running only a single main process" check_5_3="5.3 - Verify that containers are running only a single main process"
fail=0 fail=0
printcheck=0
for c in $containers; do for c in $containers; do
exec_check=$(docker exec "$c" ps -el 2>/dev/null)
if [ $? -eq 255 ]; then
warn "$check_5_3"
warn " * Docker exec fails: $c"
fail=1
fi
processes=$(docker exec "$c" ps -el 2>/dev/null | wc -l | awk '{print $1}') processes=$(docker exec "$c" ps -el 2>/dev/null | wc -l | awk '{print $1}')
if [ "$processes" -gt 5 ]; then if [ "$processes" -gt 5 ]; then
# If it's the first container, fail the test # If it's the first container, fail the test
@ -75,10 +69,22 @@ else
warn "$check_5_3" warn "$check_5_3"
warn " * Too many proccesses running: $c" warn " * Too many proccesses running: $c"
fail=1 fail=1
printcheck=1
else else
warn " * Too many proccesses running: $c" warn " * Too many proccesses running: $c"
fi fi
fi fi
exec_check=$(docker exec "$c" ps -el 2>/dev/null)
if [ $? -eq 255 ]; then
if [ $printcheck -eq 0 ]; then
warn "$check_5_3"
printcheck=1
fi
warn " * Docker exec fails: $c"
fail=1
fi
done done
# We went through all the containers and found none with toom any processes # We went through all the containers and found none with toom any processes
if [ $fail -eq 0 ]; then if [ $fail -eq 0 ]; then
@ -171,13 +177,8 @@ else
check_5_7="5.7 - Do not run ssh within containers" check_5_7="5.7 - Do not run ssh within containers"
fail=0 fail=0
printcheck=0
for c in $containers; do for c in $containers; do
exec_check=$(docker exec "$c" ps -el 2>/dev/null)
if [ $? -eq 255 ]; then
warn "$check_5_7"
warn " * Docker exec fails: $c"
fail=1
fi
processes=$(docker exec "$c" ps -el 2>/dev/null | grep -c sshd | awk '{print $1}') processes=$(docker exec "$c" ps -el 2>/dev/null | grep -c sshd | awk '{print $1}')
if [ "$processes" -ge 1 ]; then if [ "$processes" -ge 1 ]; then
@ -186,10 +187,22 @@ else
warn "$check_5_7" warn "$check_5_7"
warn " * Container running sshd: $c" warn " * Container running sshd: $c"
fail=1 fail=1
printcheck=1
else else
warn " * Container running sshd: $c" warn " * Container running sshd: $c"
fi fi
fi fi
exec_check=$(docker exec "$c" ps -el 2>/dev/null)
if [ $? -eq 255 ]; then
if [ $printcheck -eq 0 ]; then
warn "$check_5_7"
printcheck=1
fi
warn " * Docker exec fails: $c"
fail=1
fi
done done
# We went through all the containers and found none with sshd # We went through all the containers and found none with sshd
if [ $fail -eq 0 ]; then if [ $fail -eq 0 ]; then