GuillaumeHemmen/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-01 13:03:25 +01:00
Code Issues Projects Releases Packages Wiki Activity

asm-generic: Fix 32 bit __generic_cmpxchg_local

Browse source 
Commit 656e9007ef ("asm-generic: avoid __generic_cmpxchg_local
warnings") introduced a typo that means the code is incorrect for 32 bit
values. It will work fine for postive numbers, but will fail for
negative numbers on a system where longs are 64 bit.

Fixes: 656e9007ef ("asm-generic: avoid __generic_cmpxchg_local warnings")
Signed-off-by: David McKay <david.mckay@codasip.com>
Signed-off-by: Stuart Menefy <stuart.menefy@codasip.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
David McKay 2024-01-04 09:40:10 +00:00 committed by Arnd Bergmann
parent d6e81532b1
commit d93cca2f31
No known key found for this signature in database
GPG key ID: 60AB47FFC9095227
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
include/asm-generic/cmpxchg-local.h
View file

@ -34,7 +34,7 @@ static inline unsigned long __generic_cmpxchg_local(volatile void *ptr,
*(u16 *)ptr = (new & 0xffffu); *(u16 *)ptr = (new & 0xffffu);
break; break;
case 4: prev = *(u32 *)ptr; case 4: prev = *(u32 *)ptr;
if (prev == (old & 0xffffffffffu)) if (prev == (old & 0xffffffffu))
*(u32 *)ptr = (new & 0xffffffffu); *(u32 *)ptr = (new & 0xffffffffu);
break; break;
case 8: prev = *(u64 *)ptr; case 8: prev = *(u64 *)ptr;