GuillaumeHemmen/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2024-11-01 13:03:25 +01:00
Code Issues Projects Releases Packages Wiki Activity

misc: ti-st: st_kim: Convert to platform remove callback returning void

Browse source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/250337c967bdb5019a3c9fe8e0d082cd65400227.1708508896.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2024-02-21 10:53:52 +01:00 committed by Greg Kroah-Hartman
parent 74b32514f0
commit f1a70d68e5
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/misc/ti-st/st_kim.c
View file

@ -774,7 +774,7 @@ static int kim_probe(struct platform_device *pdev)
return err; return err;
} }
static int kim_remove(struct platform_device *pdev) static void kim_remove(struct platform_device *pdev)
{ {
/* free the GPIOs requested */ /* free the GPIOs requested */
struct ti_st_plat_data *pdata = pdev->dev.platform_data; struct ti_st_plat_data *pdata = pdev->dev.platform_data;
@ -798,7 +798,6 @@ static int kim_remove(struct platform_device *pdev)
kfree(kim_gdata); kfree(kim_gdata);
kim_gdata = NULL; kim_gdata = NULL;
return 0;
} }
static int kim_suspend(struct platform_device *pdev, pm_message_t state) static int kim_suspend(struct platform_device *pdev, pm_message_t state)
@ -825,7 +824,7 @@ static int kim_resume(struct platform_device *pdev)
/* entry point for ST KIM module, called in from ST Core */ /* entry point for ST KIM module, called in from ST Core */
static struct platform_driver kim_platform_driver = { static struct platform_driver kim_platform_driver = {
.probe = kim_probe, .probe = kim_probe,
.remove = kim_remove, .remove_new = kim_remove,
.suspend = kim_suspend, .suspend = kim_suspend,
.resume = kim_resume, .resume = kim_resume,
.driver = { .driver = {