mirror of
https://github.com/torvalds/linux.git
synced 2024-11-01 13:03:25 +01:00
5abffb66d1
In drm_kms_helper_poll_disable() check if output polling support is initialized before disabling polling. If not flag this as a warning. Additionally in drm_mode_config_helper_suspend() and drm_mode_config_helper_resume() calls, that re the callers of these functions, avoid invoking them if polling is not initialized. For drivers like hyperv-drm, that do not initialize connector polling, if suspend is called without this check, it leads to suspend failure with following stack [ 770.719392] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. [ 770.720592] printk: Suspending console(s) (use no_console_suspend to debug) [ 770.948823] ------------[ cut here ]------------ [ 770.948824] WARNING: CPU: 1 PID: 17197 at kernel/workqueue.c:3162 __flush_work.isra.0+0x212/0x230 [ 770.948831] Modules linked in: rfkill nft_counter xt_conntrack xt_owner udf nft_compat crc_itu_t nft_fib_inet nft_fib_ipv4 nft_fib_ipv6 nft_fib nft_reject_inet nf_reject_ipv4 nf_reject_ipv6 nft_reject nft_ct nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 ip_set nf_tables nfnetlink vfat fat mlx5_ib ib_uverbs ib_core mlx5_core intel_rapl_msr intel_rapl_common kvm_amd ccp mlxfw kvm psample hyperv_drm tls drm_shmem_helper drm_kms_helper irqbypass pcspkr syscopyarea sysfillrect sysimgblt hv_balloon hv_utils joydev drm fuse xfs libcrc32c pci_hyperv pci_hyperv_intf sr_mod sd_mod cdrom t10_pi sg hv_storvsc scsi_transport_fc hv_netvsc serio_raw hyperv_keyboard hid_hyperv crct10dif_pclmul crc32_pclmul crc32c_intel hv_vmbus ghash_clmulni_intel dm_mirror dm_region_hash dm_log dm_mod [ 770.948863] CPU: 1 PID: 17197 Comm: systemd-sleep Not tainted 5.14.0-362.2.1.el9_3.x86_64 #1 [ 770.948865] Hardware name: Microsoft Corporation Virtual Machine/Virtual Machine, BIOS Hyper-V UEFI Release v4.1 05/09/2022 [ 770.948866] RIP: 0010:__flush_work.isra.0+0x212/0x230 [ 770.948869] Code: 8b 4d 00 4c 8b 45 08 89 ca 48 c1 e9 04 83 e2 08 83 e1 0f 83 ca 02 89 c8 48 0f ba 6d 00 03 e9 25 ff ff ff 0f 0b e9 4e ff ff ff <0f> 0b 45 31 ed e9 44 ff ff ff e8 8f 89 b2 00 66 66 2e 0f 1f 84 00 [ 770.948870] RSP: 0018:ffffaf4ac213fb10 EFLAGS: 00010246 [ 770.948871] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffffff8c992857 [ 770.948872] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffff9aad82b00330 [ 770.948873] RBP: ffff9aad82b00330 R08: 0000000000000000 R09: ffff9aad87ee3d10 [ 770.948874] R10: 0000000000000200 R11: 0000000000000000 R12: ffff9aad82b00330 [ 770.948874] R13: 0000000000000001 R14: 0000000000000000 R15: 0000000000000001 [ 770.948875] FS: 00007ff1b2f6bb40(0000) GS:ffff9aaf37d00000(0000) knlGS:0000000000000000 [ 770.948878] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 770.948878] CR2: 0000555f345cb666 CR3: 00000001462dc005 CR4: 0000000000370ee0 [ 770.948879] Call Trace: [ 770.948880] <TASK> [ 770.948881] ? show_trace_log_lvl+0x1c4/0x2df [ 770.948884] ? show_trace_log_lvl+0x1c4/0x2df [ 770.948886] ? __cancel_work_timer+0x103/0x190 [ 770.948887] ? __flush_work.isra.0+0x212/0x230 [ 770.948889] ? __warn+0x81/0x110 [ 770.948891] ? __flush_work.isra.0+0x212/0x230 [ 770.948892] ? report_bug+0x10a/0x140 [ 770.948895] ? handle_bug+0x3c/0x70 [ 770.948898] ? exc_invalid_op+0x14/0x70 [ 770.948899] ? asm_exc_invalid_op+0x16/0x20 [ 770.948903] ? __flush_work.isra.0+0x212/0x230 [ 770.948905] __cancel_work_timer+0x103/0x190 [ 770.948907] ? _raw_spin_unlock_irqrestore+0xa/0x30 [ 770.948910] drm_kms_helper_poll_disable+0x1e/0x40 [drm_kms_helper] [ 770.948923] drm_mode_config_helper_suspend+0x1c/0x80 [drm_kms_helper] [ 770.948933] ? __pfx_vmbus_suspend+0x10/0x10 [hv_vmbus] [ 770.948942] hyperv_vmbus_suspend+0x17/0x40 [hyperv_drm] [ 770.948944] ? __pfx_vmbus_suspend+0x10/0x10 [hv_vmbus] [ 770.948951] dpm_run_callback+0x4c/0x140 [ 770.948954] __device_suspend_noirq+0x74/0x220 [ 770.948956] dpm_noirq_suspend_devices+0x148/0x2a0 [ 770.948958] dpm_suspend_end+0x54/0xe0 [ 770.948960] create_image+0x14/0x290 [ 770.948963] hibernation_snapshot+0xd6/0x200 [ 770.948964] hibernate.cold+0x8b/0x1fb [ 770.948967] state_store+0xcd/0xd0 [ 770.948969] kernfs_fop_write_iter+0x124/0x1b0 [ 770.948973] new_sync_write+0xff/0x190 [ 770.948976] vfs_write+0x1ef/0x280 [ 770.948978] ksys_write+0x5f/0xe0 [ 770.948979] do_syscall_64+0x5c/0x90 [ 770.948981] ? syscall_exit_work+0x103/0x130 [ 770.948983] ? syscall_exit_to_user_mode+0x12/0x30 [ 770.948985] ? do_syscall_64+0x69/0x90 [ 770.948986] ? do_syscall_64+0x69/0x90 [ 770.948987] ? do_user_addr_fault+0x1d6/0x6a0 [ 770.948989] ? do_syscall_64+0x69/0x90 [ 770.948990] ? exc_page_fault+0x62/0x150 [ 770.948992] entry_SYSCALL_64_after_hwframe+0x72/0xdc [ 770.948995] RIP: 0033:0x7ff1b293eba7 [ 770.949010] Code: 0b 00 f7 d8 64 89 02 48 c7 c0 ff ff ff ff eb b7 0f 1f 00 f3 0f 1e fa 64 8b 04 25 18 00 00 00 85 c0 75 10 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 51 c3 48 83 ec 28 48 89 54 24 18 48 89 74 24 [ 770.949011] RSP: 002b:00007ffde3912128 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 770.949012] RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 00007ff1b293eba7 [ 770.949013] RDX: 0000000000000005 RSI: 00007ffde3912210 RDI: 0000000000000004 [ 770.949014] RBP: 00007ffde3912210 R08: 000055d7dd4c9510 R09: 00007ff1b29b14e0 [ 770.949014] R10: 00007ff1b29b13e0 R11: 0000000000000246 R12: 0000000000000005 [ 770.949015] R13: 000055d7dd4c53e0 R14: 0000000000000005 R15: 00007ff1b29f69e0 [ 770.949016] </TASK> [ 770.949017] ---[ end trace e6fa0618bfa2f31d ]--- Built-on: Rhel9, Ubuntu22 Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/1706856208-9617-1-git-send-email-shradhagupta@linux.microsoft.com
259 lines
8 KiB
C
259 lines
8 KiB
C
/*
|
|
* Copyright (c) 2016 Intel Corporation
|
|
*
|
|
* Permission to use, copy, modify, distribute, and sell this software and its
|
|
* documentation for any purpose is hereby granted without fee, provided that
|
|
* the above copyright notice appear in all copies and that both that copyright
|
|
* notice and this permission notice appear in supporting documentation, and
|
|
* that the name of the copyright holders not be used in advertising or
|
|
* publicity pertaining to distribution of the software without specific,
|
|
* written prior permission. The copyright holders make no representations
|
|
* about the suitability of this software for any purpose. It is provided "as
|
|
* is" without express or implied warranty.
|
|
*
|
|
* THE COPYRIGHT HOLDERS DISCLAIM ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
|
|
* INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN NO
|
|
* EVENT SHALL THE COPYRIGHT HOLDERS BE LIABLE FOR ANY SPECIAL, INDIRECT OR
|
|
* CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE,
|
|
* DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER
|
|
* TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE
|
|
* OF THIS SOFTWARE.
|
|
*/
|
|
|
|
#include <drm/drm_atomic_helper.h>
|
|
#include <drm/drm_fb_helper.h>
|
|
#include <drm/drm_fourcc.h>
|
|
#include <drm/drm_framebuffer.h>
|
|
#include <drm/drm_modeset_helper.h>
|
|
#include <drm/drm_plane_helper.h>
|
|
#include <drm/drm_print.h>
|
|
#include <drm/drm_probe_helper.h>
|
|
|
|
/**
|
|
* DOC: aux kms helpers
|
|
*
|
|
* This helper library contains various one-off functions which don't really fit
|
|
* anywhere else in the DRM modeset helper library.
|
|
*/
|
|
|
|
/**
|
|
* drm_helper_move_panel_connectors_to_head() - move panels to the front in the
|
|
* connector list
|
|
* @dev: drm device to operate on
|
|
*
|
|
* Some userspace presumes that the first connected connector is the main
|
|
* display, where it's supposed to display e.g. the login screen. For
|
|
* laptops, this should be the main panel. Use this function to sort all
|
|
* (eDP/LVDS/DSI) panels to the front of the connector list, instead of
|
|
* painstakingly trying to initialize them in the right order.
|
|
*/
|
|
void drm_helper_move_panel_connectors_to_head(struct drm_device *dev)
|
|
{
|
|
struct drm_connector *connector, *tmp;
|
|
struct list_head panel_list;
|
|
|
|
INIT_LIST_HEAD(&panel_list);
|
|
|
|
spin_lock_irq(&dev->mode_config.connector_list_lock);
|
|
list_for_each_entry_safe(connector, tmp,
|
|
&dev->mode_config.connector_list, head) {
|
|
if (connector->connector_type == DRM_MODE_CONNECTOR_LVDS ||
|
|
connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
|
|
connector->connector_type == DRM_MODE_CONNECTOR_DSI)
|
|
list_move_tail(&connector->head, &panel_list);
|
|
}
|
|
|
|
list_splice(&panel_list, &dev->mode_config.connector_list);
|
|
spin_unlock_irq(&dev->mode_config.connector_list_lock);
|
|
}
|
|
EXPORT_SYMBOL(drm_helper_move_panel_connectors_to_head);
|
|
|
|
/**
|
|
* drm_helper_mode_fill_fb_struct - fill out framebuffer metadata
|
|
* @dev: DRM device
|
|
* @fb: drm_framebuffer object to fill out
|
|
* @mode_cmd: metadata from the userspace fb creation request
|
|
*
|
|
* This helper can be used in a drivers fb_create callback to pre-fill the fb's
|
|
* metadata fields.
|
|
*/
|
|
void drm_helper_mode_fill_fb_struct(struct drm_device *dev,
|
|
struct drm_framebuffer *fb,
|
|
const struct drm_mode_fb_cmd2 *mode_cmd)
|
|
{
|
|
int i;
|
|
|
|
fb->dev = dev;
|
|
fb->format = drm_get_format_info(dev, mode_cmd);
|
|
fb->width = mode_cmd->width;
|
|
fb->height = mode_cmd->height;
|
|
for (i = 0; i < 4; i++) {
|
|
fb->pitches[i] = mode_cmd->pitches[i];
|
|
fb->offsets[i] = mode_cmd->offsets[i];
|
|
}
|
|
fb->modifier = mode_cmd->modifier[0];
|
|
fb->flags = mode_cmd->flags;
|
|
}
|
|
EXPORT_SYMBOL(drm_helper_mode_fill_fb_struct);
|
|
|
|
/*
|
|
* This is the minimal list of formats that seem to be safe for modeset use
|
|
* with all current DRM drivers. Most hardware can actually support more
|
|
* formats than this and drivers may specify a more accurate list when
|
|
* creating the primary plane.
|
|
*/
|
|
static const uint32_t safe_modeset_formats[] = {
|
|
DRM_FORMAT_XRGB8888,
|
|
DRM_FORMAT_ARGB8888,
|
|
};
|
|
|
|
static const struct drm_plane_funcs primary_plane_funcs = {
|
|
DRM_PLANE_NON_ATOMIC_FUNCS,
|
|
};
|
|
|
|
/**
|
|
* drm_crtc_init - Legacy CRTC initialization function
|
|
* @dev: DRM device
|
|
* @crtc: CRTC object to init
|
|
* @funcs: callbacks for the new CRTC
|
|
*
|
|
* Initialize a CRTC object with a default helper-provided primary plane and no
|
|
* cursor plane.
|
|
*
|
|
* Note that we make some assumptions about hardware limitations that may not be
|
|
* true for all hardware:
|
|
*
|
|
* 1. Primary plane cannot be repositioned.
|
|
* 2. Primary plane cannot be scaled.
|
|
* 3. Primary plane must cover the entire CRTC.
|
|
* 4. Subpixel positioning is not supported.
|
|
* 5. The primary plane must always be on if the CRTC is enabled.
|
|
*
|
|
* This is purely a backwards compatibility helper for old drivers. Drivers
|
|
* should instead implement their own primary plane. Atomic drivers must do so.
|
|
* Drivers with the above hardware restriction can look into using &struct
|
|
* drm_simple_display_pipe, which encapsulates the above limitations into a nice
|
|
* interface.
|
|
*
|
|
* Returns:
|
|
* Zero on success, error code on failure.
|
|
*/
|
|
int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
|
|
const struct drm_crtc_funcs *funcs)
|
|
{
|
|
struct drm_plane *primary;
|
|
int ret;
|
|
|
|
/* possible_crtc's will be filled in later by crtc_init */
|
|
primary = __drm_universal_plane_alloc(dev, sizeof(*primary), 0, 0,
|
|
&primary_plane_funcs,
|
|
safe_modeset_formats,
|
|
ARRAY_SIZE(safe_modeset_formats),
|
|
NULL, DRM_PLANE_TYPE_PRIMARY, NULL);
|
|
if (IS_ERR(primary))
|
|
return PTR_ERR(primary);
|
|
|
|
/*
|
|
* Remove the format_default field from drm_plane when dropping
|
|
* this helper.
|
|
*/
|
|
primary->format_default = true;
|
|
|
|
ret = drm_crtc_init_with_planes(dev, crtc, primary, NULL, funcs, NULL);
|
|
if (ret)
|
|
goto err_drm_plane_cleanup;
|
|
|
|
return 0;
|
|
|
|
err_drm_plane_cleanup:
|
|
drm_plane_cleanup(primary);
|
|
kfree(primary);
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(drm_crtc_init);
|
|
|
|
/**
|
|
* drm_mode_config_helper_suspend - Modeset suspend helper
|
|
* @dev: DRM device
|
|
*
|
|
* This helper function takes care of suspending the modeset side. It disables
|
|
* output polling if initialized, suspends fbdev if used and finally calls
|
|
* drm_atomic_helper_suspend().
|
|
* If suspending fails, fbdev and polling is re-enabled.
|
|
*
|
|
* Returns:
|
|
* Zero on success, negative error code on error.
|
|
*
|
|
* See also:
|
|
* drm_kms_helper_poll_disable() and drm_fb_helper_set_suspend_unlocked().
|
|
*/
|
|
int drm_mode_config_helper_suspend(struct drm_device *dev)
|
|
{
|
|
struct drm_atomic_state *state;
|
|
|
|
if (!dev)
|
|
return 0;
|
|
/*
|
|
* Don't disable polling if it was never initialized
|
|
*/
|
|
if (dev->mode_config.poll_enabled)
|
|
drm_kms_helper_poll_disable(dev);
|
|
|
|
drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 1);
|
|
state = drm_atomic_helper_suspend(dev);
|
|
if (IS_ERR(state)) {
|
|
drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 0);
|
|
/*
|
|
* Don't enable polling if it was never initialized
|
|
*/
|
|
if (dev->mode_config.poll_enabled)
|
|
drm_kms_helper_poll_enable(dev);
|
|
|
|
return PTR_ERR(state);
|
|
}
|
|
|
|
dev->mode_config.suspend_state = state;
|
|
|
|
return 0;
|
|
}
|
|
EXPORT_SYMBOL(drm_mode_config_helper_suspend);
|
|
|
|
/**
|
|
* drm_mode_config_helper_resume - Modeset resume helper
|
|
* @dev: DRM device
|
|
*
|
|
* This helper function takes care of resuming the modeset side. It calls
|
|
* drm_atomic_helper_resume(), resumes fbdev if used and enables output polling
|
|
* if initiaized.
|
|
*
|
|
* Returns:
|
|
* Zero on success, negative error code on error.
|
|
*
|
|
* See also:
|
|
* drm_fb_helper_set_suspend_unlocked() and drm_kms_helper_poll_enable().
|
|
*/
|
|
int drm_mode_config_helper_resume(struct drm_device *dev)
|
|
{
|
|
int ret;
|
|
|
|
if (!dev)
|
|
return 0;
|
|
|
|
if (WARN_ON(!dev->mode_config.suspend_state))
|
|
return -EINVAL;
|
|
|
|
ret = drm_atomic_helper_resume(dev, dev->mode_config.suspend_state);
|
|
if (ret)
|
|
DRM_ERROR("Failed to resume (%d)\n", ret);
|
|
dev->mode_config.suspend_state = NULL;
|
|
|
|
drm_fb_helper_set_suspend_unlocked(dev->fb_helper, 0);
|
|
/*
|
|
* Don't enable polling if it is not initialized
|
|
*/
|
|
if (dev->mode_config.poll_enabled)
|
|
drm_kms_helper_poll_enable(dev);
|
|
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(drm_mode_config_helper_resume);
|