Roberto Sassu 701b38995e security: Place security_path_post_mknod() where the original IMA call was ... Commit 08abce60d6 ("security: Introduce path_post_mknod hook") introduced security_path_post_mknod(), to replace the IMA-specific call to ima_post_path_mknod(). For symmetry with security_path_mknod(), security_path_post_mknod() was called after a successful mknod operation, for any file type, rather than only for regular files at the time there was the IMA call. However, as reported by VFS maintainers, successful mknod operation does not mean that the dentry always has an inode attached to it (for example, not for FIFOs on a SAMBA mount). If that condition happens, the kernel crashes when security_path_post_mknod() attempts to verify if the inode associated to the dentry is private. Move security_path_post_mknod() where the ima_post_path_mknod() call was, which is obviously correct from IMA/EVM perspective. IMA/EVM are the only in-kernel users, and only need to inspect regular files. Reported-by: Steve French <smfrench@gmail.com> Closes: https://lore.kernel.org/linux-kernel/CAH2r5msAVzxCUHHG8VKrMPUKQHmBpE6K9_vjhgDa1uAvwx4ppw@mail.gmail.com/ Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Fixes: 08abce60d6 ("security: Introduce path_post_mknod hook") Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Reviewed-by: Christian Brauner <brauner@kernel.org> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> Acked-by: Paul Moore <paul@paul-moore.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2024-04-03 10:21:32 -07:00
..
apparmor	lsm: use 32-bit compatible data types in LSM syscalls	2024-03-14 11:31:26 -04:00
bpf
integrity	lsm/stable-6.9 PR 20240312	2024-03-12 20:03:34 -07:00
keys
landlock	landlock: Use f_cred in security_file_open() hook	2024-03-08 18:22:16 +01:00
loadpin
lockdown
safesetid
selinux	selinux: avoid dereference of garbage after mount failure	2024-04-01 23:32:35 -04:00
smack	lsm: use 32-bit compatible data types in LSM syscalls	2024-03-14 11:31:26 -04:00
tomoyo	tomoyo: fix UAF write bug in tomoyo_write_control()	2024-03-01 11:14:00 -08:00
yama
commoncap.c
device_cgroup.c
inode.c
Kconfig
Kconfig.hardening
lsm_audit.c
lsm_syscalls.c	lsm: use 32-bit compatible data types in LSM syscalls	2024-03-14 11:31:26 -04:00
Makefile
min_addr.c
security.c	security: Place security_path_post_mknod() where the original IMA call was	2024-04-03 10:21:32 -07:00