improvements #1

2020-04-09T11:50:35Z

imranMnts commented

2020-04-09 11:50:35 +00:00

(Migrated from github.com)

add js exception handler
add crash report services
improve init function
add unit tests

- add js exception handler - add crash report services - improve init function - add unit tests

mvspike (Migrated from github.com) reviewed

2020-04-13 09:36:55 +00:00

README.md

					
				@ -1,12 +1,46 @@

				# react-native-logging

				# React Native Logging Tools

Typo: remove "to" at the end

I would say: "Plug multiple analytics libraries (<-link to the list below->) to your project"

README.md

					
				@ -10,3 +43,4 @@

				---

				## Usage

Typo: bu => be

I would not put too much details in the usage section. I prefer keeping it as light as possible with a complete example. Then, I would create another "API documentation" section with a more detailed documentation of the initialization function and all the existing APIs

src/index.ts

					
				@ -1,35 +1,15 @@

				import { reactotron, reactotronWithRedux } from './reactotron';

				import { createFirebaseLogger, createSentryLogger } from './loggers';

				import { IConfig, IReactotron } from './model/config';

				import { setupReactotron, setupReactotronWithRedux } from './modules/reactotron';

I would keep the index.ts light with just the import/export statements. The code could be moved to one or multiple files (it might be better to extract the logic of each feature (logger, crash, reactotron, ...) and put it in a separate file)

src/loggers/crashlytics.ts

Not sure it is a good practice to use console.log in the lib. Maybe we should re-throw the error or at least disable the logs when we are not in DEV mode (or give control of that logs to the project using the library).

Sign in to join this conversation.

No reviewers