unneeded require cycles #18

New issue

Open

opened 2021-01-16 14:00:04 +00:00 by GuillaumeHemmen · 0 comments

GuillaumeHemmen commented

2021-01-16 14:00:04 +00:00

(Migrated from github.com)

Description:

It seems that there is a few require cycle in the library.

Steps To Reproduce

integrate the library
launch it in debug mode and watch the metro console.

Expected Results

no require cycle warning should appear

Snack, code example, screenshot, or link to a repository:

Console example

[Sat Jan 16 2021 14:56:57.491]  WARN     Require cycle: node_modules/react-native-logging-tools/src/modules/init/index.ts -> node_modules/react-native-logging-tools/src/exceptionHandler.ts -> node_modules/react-native-logging-tools/src/modules/events/index.ts -> node_modules/react-native-logging-tools/src/modules/init/index.ts

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
[Sat Jan 16 2021 14:56:57.491]  WARN     Require cycle: node_modules/react-native-logging-tools/src/modules/init/index.ts -> node_modules/react-native-logging-tools/src/flipper/index.ts -> node_modules/react-native-logging-tools/src/modules/init/index.ts

## Description: It seems that there is a few require cycle in the library. ## Steps To Reproduce 1. integrate the library 2. launch it in debug mode and watch the metro console. ## Expected Results no require cycle warning should appear ## Snack, code example, screenshot, or link to a repository: Console example ``` [Sat Jan 16 2021 14:56:57.491] WARN Require cycle: node_modules/react-native-logging-tools/src/modules/init/index.ts -> node_modules/react-native-logging-tools/src/exceptionHandler.ts -> node_modules/react-native-logging-tools/src/modules/events/index.ts -> node_modules/react-native-logging-tools/src/modules/init/index.ts Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle. [Sat Jan 16 2021 14:56:57.491] WARN Require cycle: node_modules/react-native-logging-tools/src/modules/init/index.ts -> node_modules/react-native-logging-tools/src/flipper/index.ts -> node_modules/react-native-logging-tools/src/modules/init/index.ts ```