Update Tealium initialisation to v2 TealiumConfig properties #19

Merged
Soliman13 merged 5 commits from develop into develop 2021-03-03 12:30:07 +00:00
Soliman13 commented 2021-03-03 09:39:34 +00:00 (Migrated from github.com)

The TealiumConfig properties have changed in v2.0.2 and we are not able to initialise Tealium with the new properties.

This PR is about handling the new TealiumConfig properties

The TealiumConfig properties have changed in v2.0.2 and we are not able to initialise Tealium with the new properties. This PR is about handling the new TealiumConfig properties
imranMnts (Migrated from github.com) reviewed 2021-03-03 09:49:47 +00:00
@ -1,16 +1,8 @@
import { ITealium } from '../../model/tealium';
import { ITealiumConfig } from '../../model/tealium';
imranMnts (Migrated from github.com) commented 2021-03-03 09:49:47 +00:00

https://docs.tealium.com/platforms/react-native-v1/install/#initialize

It will not work with v1 of Tealium.
Please update the readme + package.json peerDependencies to upgrade the supported version to v2

https://docs.tealium.com/platforms/react-native-v1/install/#initialize It will not work with v1 of Tealium. Please update the readme + package.json peerDependencies to upgrade the supported version to v2
GuillaumeHemmen commented 2021-03-03 10:31:16 +00:00 (Migrated from github.com)

@Soliman13 tealium-react-native is still to be udated in package.json > peerDependencies.

@Soliman13 `tealium-react-native` is still to be udated in `package.json` > `peerDependencies`.
imranMnts (Migrated from github.com) reviewed 2021-03-03 11:14:30 +00:00
@ -1,5 +1,10 @@
# Changelog
imranMnts (Migrated from github.com) commented 2021-03-03 11:14:30 +00:00

Not need to detail the changes on Tealium side.
To keep a clear changelog, you can just mention the support of Tealium's version in our library which changed to v2 from v1 should be enough.

Not need to detail the changes on Tealium side. To keep a clear changelog, you can just mention the support of Tealium's version in our library which changed to v2 from v1 should be enough.
imranMnts (Migrated from github.com) reviewed 2021-03-03 11:24:32 +00:00
imranMnts (Migrated from github.com) approved these changes 2021-03-03 12:01:42 +00:00
Sign in to join this conversation.
No description provided.