#56 - Make Sonar analysis step optional to support fork CI #57

Merged

GuillaumeHemmen merged 3 commits from 56-Make-Sonar-analysis-step-optional-to-support-fork-CI into master 2026-04-13 11:31:15 +00:00

Conversation 0 Commits 3 Files changed 6 +108 -34

GuillaumeHemmen commented 2026-04-13 11:23:28 +00:00

Owner

Copy link

Description

Make the Sonar analysis step optional across all CI workflows to support forked repositories. Sonar-specific configuration (host URL, project key, project name) is moved out of sonar-project.properties and into CI variables/secrets. All four workflows now skip the Sonar job gracefully when the required values are not configured, so fork CI passes cleanly without any Sonar setup.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Performance improvement
• Refactoring (no functional changes)
• CI/CD update

Related Issue

Fixes #56

Testing

• Unit tests added/updated
• Manual testing performed
• Tested on iOS
• Tested on Android

No application code was changed. CI changes can be validated by verifying that:

• The upstream repository with all values configured continues to run Sonar as before.
• On tag.yaml, the publish job still runs when the Sonar job is skipped.

Breaking Changes

None. The Sonar job behaviour is unchanged for repositories that have all required values configured.

Checklist

• Code follows the project's code style (Prettier, ESLint)
• TypeScript types are properly defined
• Tests pass locally
• Documentation updated (if needed)
• CI checks pass (Prettier, TypeScript, Lint, Tests, Sonar)

Additional Notes

Changed files:

• .forgejo/workflows/pr.yaml — added if condition + env vars (SONAR_HOST_URL, SONAR_PROJECT_KEY, SONAR_PROJECT_NAME) + passed via -D flags
• .forgejo/workflows/master.yaml — same changes
• .forgejo/workflows/dev.yaml — same changes
• .forgejo/workflows/tag.yaml — same changes + publish job updated with if: always() && (needs.sonar.result == 'success' || needs.sonar.result == 'skipped') to prevent blocking on skipped Sonar
• sonar-project.properties — removed sonar.host.url, sonar.projectKey, sonar.projectName
• CONTRIBUTING.md — added "CI & Sonar Analysis" section documenting the required secret and variables for fork contributors

Required CI configuration for Sonar to run:

Name	Type	Description
SONAR_TOKEN	Secret	Authentication token
SONAR_HOST_URL	Variable	SonarQube instance URL
SONAR_PROJECT_KEY	Variable	Project key in SonarQube
SONAR_PROJECT_NAME	Variable	Project name in SonarQube

## Description Make the Sonar analysis step optional across all CI workflows to support forked repositories. Sonar-specific configuration (`host URL`, `project key`, `project name`) is moved out of `sonar-project.properties` and into CI variables/secrets. All four workflows now skip the Sonar job gracefully when the required values are not configured, so fork CI passes cleanly without any Sonar setup. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Performance improvement - [ ] Refactoring (no functional changes) - [x] CI/CD update ## Related Issue Fixes #56 ## Testing - [ ] Unit tests added/updated - [ ] Manual testing performed - [ ] Tested on iOS - [ ] Tested on Android No application code was changed. CI changes can be validated by verifying that: - The upstream repository with all values configured continues to run Sonar as before. - On `tag.yaml`, the `publish` job still runs when the Sonar job is skipped. ## Breaking Changes None. The Sonar job behaviour is unchanged for repositories that have all required values configured. ## Checklist - [x] Code follows the project's code style (Prettier, ESLint) - [x] TypeScript types are properly defined - [x] Tests pass locally - [x] Documentation updated (if needed) - [x] CI checks pass (Prettier, TypeScript, Lint, Tests, Sonar) ## Additional Notes **Changed files:** - `.forgejo/workflows/pr.yaml` — added `if` condition + env vars (`SONAR_HOST_URL`, `SONAR_PROJECT_KEY`, `SONAR_PROJECT_NAME`) + passed via `-D` flags - `.forgejo/workflows/master.yaml` — same changes - `.forgejo/workflows/dev.yaml` — same changes - `.forgejo/workflows/tag.yaml` — same changes + `publish` job updated with `if: always() && (needs.sonar.result == 'success' || needs.sonar.result == 'skipped')` to prevent blocking on skipped Sonar - `sonar-project.properties` — removed `sonar.host.url`, `sonar.projectKey`, `sonar.projectName` - `CONTRIBUTING.md` — added "CI & Sonar Analysis" section documenting the required secret and variables for fork contributors **Required CI configuration for Sonar to run:** | Name | Type | Description | |---|---|---| | `SONAR_TOKEN` | Secret | Authentication token | | `SONAR_HOST_URL` | Variable | SonarQube instance URL | | `SONAR_PROJECT_KEY` | Variable | Project key in SonarQube | | `SONAR_PROJECT_NAME` | Variable | Project name in SonarQube |

GuillaumeHemmen added 1 commit 2026-04-13 11:23:28 +00:00

#56 - make Sonar analysis optional to support fork CI, update documentation b3bf88f2c2

GuillaumeHemmen added 1 commit 2026-04-13 11:26:43 +00:00

#56 - remove condition for publish job 21bb04032e

GuillaumeHemmen added 1 commit 2026-04-13 11:27:54 +00:00

#56 - improve CONTRIBUTING.md formatting for readability and consistency edbe25034f

GuillaumeHemmen scheduled this pull request to auto merge when all checks succeed 2026-04-13 11:29:58 +00:00

GuillaumeHemmen canceled auto merging this pull request when all checks succeed 2026-04-13 11:30:28 +00:00

GuillaumeHemmen merged commit f159d41bcd into master 2026-04-13 11:31:15 +00:00

GuillaumeHemmen deleted branch 56-Make-Sonar-analysis-step-optional-to-support-fork-CI 2026-04-13 11:31:15 +00:00

GuillaumeHemmen referenced this pull request from a commit 2026-04-13 11:31:15 +00:00

#56 - Make Sonar analysis step optional to support fork CI (#57)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something isn't working

  

dependencies

Pull requests that update a dependency file

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

bug

dependencies

documentation

duplicate

enhancement

good first issue

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

openrn/react-native-logging-tools!57

No description provided.